Update iam_policy.md #801
Update iam_policy.md #801
Conversation
Updated doc with - two new roles specific to HCP Vault Secrets App Manager and App secret reader - Updated documentation links to developer portal
|
|
|
@sahnikan I can review for cloud-identity, but could you please fix the Check Generated Docs and Changelog Check build failures first? |
Added changelog
Updated page with new HCP Vault Secrets Roles App Manager and App Secret Reader
Modified Example
There was a problem hiding this comment.
Looks reasonable from my perspective - approving for @hashicorp/cloud-identity . I think you may need approval from someone else before this can be merged.
Please commit my suggestion in .changelog/801.txt - documentation changes appear to use the Documentation: prefix.
Co-authored-by: Kenneth J. Pronovici <pronovic@users.noreply.github.com>
docs/data-sources/iam_policy.md
Outdated
| The basic roles can be referenced as follows: | ||
|
|
||
| * `roles/owner` | ||
| * `roles/admin` | ||
| * `roles/contributor` | ||
| * `roles/viewer` | ||
|
|
||
| You can now assign HCP Vault Secrets specific roles, please see [Documentation](https://developer.hashicorp.com/hcp/docs/hcp/admin/iam/users#project) |
There was a problem hiding this comment.
I personally would prefer we remove the "You can now" verbiage. Who is going to come clean that up when it has been available for months?
There was a problem hiding this comment.
Ok from foundations. Please test it prod with the FGR before merging and consider addressing @dadgar comment below.
Updated copy in template file
Updated doc with