Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'name' field validation to be limited to 53 characters #1228

Merged
merged 3 commits into from
Aug 17, 2023

Conversation

arybolovlev
Copy link
Contributor

Description

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
$ make testacc TESTARGS="-count 1 -run 'TestAccResourceRelease_validation'"

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test "./helm" -v -count 1 -run 'TestAccResourceRelease_validation' -timeout 10m
...
=== RUN   TestAccResourceRelease_validation
--- PASS: TestAccResourceRelease_validation (0.26s)
PASS
ok  	github.com/hashicorp/terraform-provider-helm/helm	1.357s

Release Note

Release note for CHANGELOG:

`resource/helm_release`: add `name` field validation to be limited to 53 characters.

References

Fix: #1224

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@arybolovlev arybolovlev requested a review from a team as a code owner August 17, 2023 07:37
Copy link
Member

@alexsomesan alexsomesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 😁

@arybolovlev arybolovlev merged commit 7015b80 into main Aug 17, 2023
16 checks passed
@arybolovlev arybolovlev deleted the add-chart-name-validation branch August 17, 2023 09:04
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm Release Name not Validated on Plan
2 participants