Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log values.yaml in case of errors and filtering sensitive values #182

Merged
merged 1 commit into from
Jan 11, 2019

Conversation

meyskens
Copy link
Contributor

in #153 the debug log for values was removed.
This adds it back in a form where it replaces sensitive values.

Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
@ghost ghost added the size/XS label Jan 11, 2019
@legal90
Copy link
Contributor

legal90 commented Jan 11, 2019

@meyskens #150 also includes the introduction of new attribute - overrides, which will be saved in state. Maybe that could be used for the debugging purposes too ?

@rporres
Copy link

rporres commented Jan 11, 2019

LGTM

@legal90 Your comment is more related to #150 than about the code in this very PR, isn't it?

@legal90
Copy link
Contributor

legal90 commented Jan 11, 2019

@meyskens Ah, you're right. Sorry, I didn't notice that this is a PR, no an issue (feature proposal).
I actually like the implementation of sensitive data suppression here 👍

And we might need to rework #150 a little bit, after this one is merged.

@meyskens meyskens merged commit bfd7d79 into hashicorp:master Jan 11, 2019
@meyskens meyskens deleted the log-sensitive branch January 11, 2019 10:17
@ghost ghost locked and limited conversation to collaborators Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants