helm_release: Suppress diff of "keyring" and "devel" attributes #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This attribute stores only the local path. Changes doesn't necessarily affect the resource state.
I guess, that should be a unit test for the |
legal90
force-pushed
the
suppress-diff
branch
from
7fec90d
to
430e328
Compare
legal90
force-pushed
the
suppress-diff
branch
from
430e328
to
821468f
Compare
|
The real test here would be to have a test for verify... Since it's out of the scope of your change, I will merge it as it is. Thanks for your contribution. |
rporres
approved these changes
Feb 8, 2019
|
@rporres Thank you! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppress diff of
develattribute ifversionis set. In this casedevelattribute is not used at all and its value shouldn't affect the resource state.Suppress diff of "keyring" attribute regardless of anything else. This attribute is only used for verifying chart on the download phase, and it is just a local path. So its value in the terraform state doesn't really matter.
Fixes #52