Remove -i from 'go test' to allow running unit tests locally with go 1.11.x and GO111MODULE=on

[pdecat]

With GO111MODULE=on, running tests locally fail:

# make test
==> Checking that code complies with gofmt requirements...
go test -i $(go list ./... |grep -v 'vendor') || exit 1
go test golang_org/x/crypto/cryptobyte/asn1: open /usr/local/go/pkg/linux_amd64/vendor/golang_org/x/crypto/cryptobyte/asn1.a: permission denied
go test golang_org/x/net/dns/dnsmessage: open /usr/local/go/pkg/linux_amd64/vendor/golang_org/x/net/dns/dnsmessage.a: permission denied
go test golang_org/x/crypto/curve25519: open /usr/local/go/pkg/linux_amd64/vendor/golang_org/x/crypto/curve25519.a: permission denied
go test golang_org/x/crypto/internal/chacha20: open /usr/local/go/pkg/linux_amd64/vendor/golang_org/x/crypto/internal/chacha20.a: permission denied
go test golang_org/x/crypto/poly1305: open /usr/local/go/pkg/linux_amd64/vendor/golang_org/x/crypto/poly1305.a: permission denied
go test golang_org/x/text/transform: open /usr/local/go/pkg/linux_amd64/vendor/golang_org/x/text/transform.a: permission denied
go test golang_org/x/net/http2/hpack: open /usr/local/go/pkg/linux_amd64/vendor/golang_org/x/net/http2/hpack.a: permission denied
go test golang_org/x/text/unicode/bidi: open /usr/local/go/pkg/linux_amd64/vendor/golang_org/x/text/unicode/bidi.a: permission denied
make: *** [GNUmakefile:25: test] Error 1

The fix will be in go 1.12: golang/go#27285

But won't be backported to go 1.11:

This has a simple workaround (stop using -i) and the fix is invasive (renaming src/vendor), so probably not worth backporting.

cf. golang/go#27389 (comment)

cc @alexsomesan

[pdecat]

I've just checked and there's the same issue with terraform-provider-kubernetes.

terraform-provider-aws does not have the -i: https://github.com/terraform-providers/terraform-provider-aws/blob/master/GNUmakefile#L14

[alexsomesan]

LGTM

This didn't manifest for me because my GOROOT is under $HOME on my machine (installed via asdf).

[pdecat]

FWIW, I install golang on Ubuntu with godeb hence the restricted path.