Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated documentation #209

Merged
merged 3 commits into from
Feb 8, 2019
Merged

Updated documentation #209

merged 3 commits into from
Feb 8, 2019

Conversation

rporres
Copy link

@rporres rporres commented Feb 8, 2019

  • Added missing attributes
  • Reordered to make it easier to check attributes with the code
  • Removed importing commands which do not work for the moment

Signed-off-by: Rafael Porres Molina rafa@sourced.tech

* Added missing attributes
* Reordered to make it easier to check attributes with the code
* Removed importing commands which do not work for the moment

Signed-off-by: Rafael Porres Molina <rafa@sourced.tech>
@legal90
Copy link
Contributor

legal90 commented Feb 8, 2019

Maybe we should also make the example snippet more detailed? Like I tried to do here:
https://github.com/terraform-providers/terraform-provider-helm/pull/184/files#diff-7e12a07998cff3f121044250fda42c9eR19

@rporres
Copy link
Author

rporres commented Feb 8, 2019

Sure, @legal90. I will make the example snippet more detailed

Rafael Porres Molina added 2 commits February 8, 2019 11:27
Signed-off-by: Rafael Porres Molina <rafa@sourced.tech>
Signed-off-by: Rafael Porres Molina <rafa@sourced.tech>
@ghost ghost added size/S and removed size/XS labels Feb 8, 2019
@rporres rporres merged commit 0ff02e1 into master Feb 8, 2019
@rporres rporres deleted the update-resources-documentation branch February 8, 2019 11:02
@ghost ghost locked and limited conversation to collaborators Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants