Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added load_config_file option to the provider k8s part #231

Merged
merged 2 commits into from
Mar 7, 2019

Conversation

meyskens
Copy link
Contributor

@meyskens meyskens commented Mar 7, 2019

Fixes #230

Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
@rporres
Copy link

rporres commented Mar 7, 2019

Shouldn’t this be feasible setting in_cluster to false? I mean, I like much more the load_config_file name, but I fail to see the difference between both or why we should keep both (when it would be useful, I mean)

We may want to deprecate in_cluster in favour of load_config_file so that we're in-sync with the k8s provider

@rporres
Copy link

rporres commented Mar 7, 2019

The problem here is that in_cluster is kinda broken. It should avoid loading .kube/config as it should call kubernets InClusterConfig function: https://godoc.org/k8s.io/client-go/rest#InClusterConfig

There can be two situations why you don't want to load .kube/config

  • You're running inside a pod and you want to authenticate using the service account k8s gives to pods
  • You don't want it for your own personal reasons

Let's merge this as it is. I will update #68 to signal that it has still work to do

@rporres rporres merged commit 1b29120 into master Mar 7, 2019
@rporres rporres deleted the load_config_file branch March 7, 2019 12:11
@ghost ghost locked and limited conversation to collaborators Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding load_config_file argument
2 participants