Remove ForceNew on repo and chart changes #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
@rporres @meyskens @alexsomesan Could anyone review this PR and provide the feedback? IMO, it totally makes sense to remove |
|
We have been hit hard by this one lately. Anything we can do to help moving this forward? |
Starefossen
approved these changes
Jul 17, 2019
|
Apologies, this had fallen off my radar. Makes total sense. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #173
helm upgradedoes not delete the release when the chart/repo are changed. The Helm provider should not too.I tested this by changing a chart/repo and the upgrade worked fine.