Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update helm dependency to v2.14.3 #312

Merged
merged 1 commit into from Sep 10, 2019

Conversation

karuppiah7890
Copy link
Contributor

@karuppiah7890 karuppiah7890 commented Aug 2, 2019

Fixes #311

Updated and vendored in the dependencies

A file in BurntSushi/toml also got vendored, looks like it was not updated previously. I hope that's not an issue, or I'll create a separate PR for that

Copy link
Contributor

@aaronmell aaronmell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karuppiah7890
Copy link
Contributor Author

Pinging contributors who have recently reviewed other PRs 🙈

@meyskens @alexsomesan

@pdecat
Copy link
Contributor

pdecat commented Sep 9, 2019

Hi, the default tiller image is usually also updated to match the library version:
https://github.com/terraform-providers/terraform-provider-helm/blob/a8e657341b68c09f901736974aee3aeccdd38be9/helm/provider.go#L73

Update: documentation too: https://github.com/terraform-providers/terraform-provider-helm/blame/a8e657341b68c09f901736974aee3aeccdd38be9/website/docs/index.html.markdown#L91

Copy link

@rporres rporres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update default tiller version as requested by @pdecat in #312 (comment)

@karuppiah7890
Copy link
Contributor Author

Updated 😄

@rporres rporres merged commit f924101 into hashicorp:master Sep 10, 2019
@karuppiah7890 karuppiah7890 deleted the update-helm branch September 10, 2019 09:09
@ghost ghost locked and limited conversation to collaborators Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use helm v2.14.3
4 participants