Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove usage of config pkg #334

Merged
merged 1 commit into from
Sep 12, 2019
Merged

remove usage of config pkg #334

merged 1 commit into from
Sep 12, 2019

Conversation

appilon
Copy link
Contributor

@appilon appilon commented Sep 11, 2019

In preparation for the upcoming standalone SDK. We are removing the usage of a few removed/deprecated functions and packages. Upgraded terraform to v0.12.8

@appilon
remove usage of config pkg
c5599dd 
update terraform sdk to v0.12.8
@ghost ghost added the size/XXL label Sep 11, 2019
@appilon appilon requested review from alexsomesan and a team September 11, 2019 02:35
radeksimko
radeksimko approved these changes Sep 12, 2019
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nitpick; for next time) it would be great to keep dependency changes in a separate commit.

@appilon
Copy link
Contributor Author

appilon commented Sep 12, 2019

seems like acceptance tests are broken on master

@alexsomesan
Copy link
Member

There was a problem with the CI configuration (outdated parameters).
Tests in master are passing (now in CI too).

alexsomesan
alexsomesan approved these changes Sep 12, 2019
View reviewed changes
Copy link
Member

@alexsomesan alexsomesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
CI is green.

@appilon appilon merged commit fe2b905 into master Sep 12, 2019
@appilon appilon deleted the appilon/remove-config-pkg branch September 12, 2019 22:35
@ghost ghost locked and limited conversation to collaborators Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radeksimko radeksimko radeksimko approved these changes

@alexsomesan alexsomesan alexsomesan approved these changes

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@appilon @alexsomesan @radeksimko