This repository has been archived by the owner on Dec 5, 2020. It is now read-only.
Update vendored Ignition to 0.34.0 #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
LorbusChris
force-pushed
the
ign0.33.0
branch
from
e3e2eda
to
a97472b
Compare
This was referenced Dec 6, 2019
LorbusChris
force-pushed
the
ign0.33.0
branch
from
a97472b
to
cb3ea92
Compare
LorbusChris
changed the title
|
Updated PR to use newly released Ignition 0.34.0 |
alexsomesan
approved these changes
Dec 12, 2019
There was a problem hiding this comment.
LGTM.
Test pass
~/workspace/terraform-provider-ignition(pr/LorbusChris/63) » make testacc alex@MacBook-Pro-2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -timeout 120m
? github.com/terraform-providers/terraform-provider-ignition [no test files]
=== RUN TestProvider
--- PASS: TestProvider (0.00s)
=== RUN TestIgnitionFileReplace
--- PASS: TestIgnitionFileReplace (0.03s)
=== RUN TestIgnitionFileAppend
--- PASS: TestIgnitionFileAppend (0.03s)
=== RUN TestIgnitionFileReplaceNoVerification
--- PASS: TestIgnitionFileReplaceNoVerification (0.03s)
=== RUN TestIgnitionFileAppendNoVerification
--- PASS: TestIgnitionFileAppendNoVerification (0.03s)
=== RUN TestIgnitionConfigDisks
--- PASS: TestIgnitionConfigDisks (0.04s)
=== RUN TestIgnitionConfigArrays
--- PASS: TestIgnitionConfigArrays (0.03s)
=== RUN TestIgnitionConfigFilesystems
--- PASS: TestIgnitionConfigFilesystems (0.04s)
=== RUN TestIgnitionConfigFiles
--- PASS: TestIgnitionConfigFiles (0.04s)
=== RUN TestIgnitionConfigSystemd
--- PASS: TestIgnitionConfigSystemd (0.03s)
=== RUN TestIgnitionConfigNetworkd
--- PASS: TestIgnitionConfigNetworkd (0.03s)
=== RUN TestIgnitionConfigUsers
--- PASS: TestIgnitionConfigUsers (0.04s)
=== RUN TestIgnitionConfigGroupss
--- PASS: TestIgnitionConfigGroupss (0.03s)
=== RUN TestIgnitionDirectory
--- PASS: TestIgnitionDirectory (0.03s)
=== RUN TestIgnitionDirectoryInvalidMode
--- PASS: TestIgnitionDirectoryInvalidMode (0.01s)
=== RUN TestIgnitionDirectoryInvalidPath
--- PASS: TestIgnitionDirectoryInvalidPath (0.01s)
=== RUN TestIgnitionDisk
--- PASS: TestIgnitionDisk (0.03s)
=== RUN TestIgnitionDiskInvalidDevice
--- PASS: TestIgnitionDiskInvalidDevice (0.01s)
=== RUN TestIgnitionDiskInvalidPartition
--- PASS: TestIgnitionDiskInvalidPartition (0.01s)
=== RUN TestIgnitionFile
--- PASS: TestIgnitionFile (0.04s)
=== RUN TestIgnitionFileInvalidMode
--- PASS: TestIgnitionFileInvalidMode (0.01s)
=== RUN TestIgnitionFileInvalidPath
--- PASS: TestIgnitionFileInvalidPath (0.01s)
=== RUN TestIgnitionFilesystem
--- PASS: TestIgnitionFilesystem (0.04s)
=== RUN TestIgnitionFilesystemInvalidPath
--- PASS: TestIgnitionFilesystemInvalidPath (0.01s)
=== RUN TestIgnitionFilesystemInvalidPathAndMount
--- PASS: TestIgnitionFilesystemInvalidPathAndMount (0.01s)
=== RUN TestIgnitionGroup
--- PASS: TestIgnitionGroup (0.03s)
=== RUN TestIgnitionLink
--- PASS: TestIgnitionLink (0.03s)
=== RUN TestIgnitionLinkInvalidPath
--- PASS: TestIgnitionLinkInvalidPath (0.01s)
=== RUN TestIgnitionNetworkdUnit
--- PASS: TestIgnitionNetworkdUnit (0.03s)
=== RUN TestIgnitionRaid
--- PASS: TestIgnitionRaid (0.03s)
=== RUN TestIgnitionRaidInvalidLevel
--- PASS: TestIgnitionRaidInvalidLevel (0.01s)
=== RUN TestIgnitionRaidInvalidDevices
--- PASS: TestIgnitionRaidInvalidDevices (0.01s)
=== RUN TestIgnitionSystemdUnit
--- PASS: TestIgnitionSystemdUnit (0.03s)
=== RUN TestIgnitionSystemdUnitEmptyContentWithDropIn
--- PASS: TestIgnitionSystemdUnitEmptyContentWithDropIn (0.03s)
=== RUN TestIgnitionSystemdUnit_emptyContent
--- PASS: TestIgnitionSystemdUnit_emptyContent (0.03s)
=== RUN TestIgnitionSystemUnitInvalidName
--- PASS: TestIgnitionSystemUnitInvalidName (0.01s)
=== RUN TestIgnitionSystemUnitInvalidContent
--- PASS: TestIgnitionSystemUnitInvalidContent (0.01s)
=== RUN TestIgnitionUser
--- PASS: TestIgnitionUser (0.04s)
PASS
ok github.com/terraform-providers/terraform-provider-ignition/ignition 1.440s
------------------------------------------------------------
~/workspace/terraform-provider-ignition(pr/LorbusChris/63) » make test alex@MacBook-Pro-2
==> Checking that code complies with gofmt requirements...
go test -i $(go list ./... |grep -v 'vendor') || exit 1
echo $(go list ./... |grep -v 'vendor') | \
xargs -t -n4 go test -timeout=30s -parallel=4
go test -timeout=30s -parallel=4 github.com/terraform-providers/terraform-provider-ignition github.com/terraform-providers/terraform-provider-ignition/ignition
? github.com/terraform-providers/terraform-provider-ignition [no test files]
ok github.com/terraform-providers/terraform-provider-ignition/ignition 1.307s
------------------------------------------------------------
|
@alexsomesan thank you for cutting a new release as well! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version of Ignition that is currently vendored is outdated, this PR updates it.
Ignition 0.34.0 is the latest version supporting Spec version 2.x