Use TestStep.ExpectedDiffChanges() to ensure resources are properly c…

…reated/updated/recreate between acceptance test steps
hashicorp · Feb 19, 2020 · 50e1b83 · 50e1b83
1 parent 445c4ea
commit 50e1b83
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/kubernetes/resource_kubernetes_job_test.go b/kubernetes/resource_kubernetes_job_test.go
@@ -22,7 +22,8 @@ func TestAccKubernetesJob_basic(t *testing.T) {
 		CheckDestroy:  testAccCheckKubernetesJobDestroy,
 		Steps: []resource.TestStep{
 			{
-				Config: testAccKubernetesJobConfig_basic(name),
+				Config:              testAccKubernetesJobConfig_basic(name),
+				ExpectedDiffChanges: map[string]terraform.DiffChangeType{"kubernetes_job.test": terraform.DiffCreate},
 				Check: resource.ComposeAggregateTestCheckFunc(
 					testAccCheckKubernetesJobExists("kubernetes_job.test", &conf),
 					resource.TestCheckResourceAttr("kubernetes_job.test", "metadata.0.name", name),
@@ -40,7 +41,8 @@ func TestAccKubernetesJob_basic(t *testing.T) {
 				),
 			},
 			{
-				Config: testAccKubernetesJobConfig_modified(name),
+				Config:              testAccKubernetesJobConfig_modified(name),
+				ExpectedDiffChanges: map[string]terraform.DiffChangeType{"kubernetes_job.test": terraform.DiffUpdate},
 				Check: resource.ComposeAggregateTestCheckFunc(
 					testAccCheckKubernetesJobExists("kubernetes_job.test", &conf),
 					resource.TestCheckResourceAttr("kubernetes_job.test", "metadata.0.name", name),
@@ -60,7 +62,8 @@ func TestAccKubernetesJob_basic(t *testing.T) {
 				),
 			},
 			{
-				Config: testAccKubernetesJobConfig_recreated_selector(name),
+				Config:              testAccKubernetesJobConfig_recreated_selector(name),
+				ExpectedDiffChanges: map[string]terraform.DiffChangeType{"kubernetes_job.test": terraform.DiffDestroyCreate},
 				Check: resource.ComposeAggregateTestCheckFunc(
 					testAccCheckKubernetesJobExists("kubernetes_job.test", &conf),
 					resource.TestCheckResourceAttr("kubernetes_job.test", "metadata.0.name", name),
@@ -82,7 +85,8 @@ func TestAccKubernetesJob_basic(t *testing.T) {
 				),
 			},
 			{
-				Config: testAccKubernetesJobConfig_recreated_image(name),
+				Config:              testAccKubernetesJobConfig_recreated_image(name),
+				ExpectedDiffChanges: map[string]terraform.DiffChangeType{"kubernetes_job.test": terraform.DiffDestroyCreate},
 				Check: resource.ComposeAggregateTestCheckFunc(
 					testAccCheckKubernetesJobExists("kubernetes_job.test", &conf),
 					resource.TestCheckResourceAttr("kubernetes_job.test", "metadata.0.name", name),