r/pod+replication_controller: Add validation for file mode bits

kubernetes/schema_pod_spec.go

@@ -188,9 +188,10 @@ func volumeSchema() *schema.Resource {
 					},
 				},
 				"default_mode": {
-					Type:        schema.TypeInt,
-					Description: "Optional: mode bits to use on created files by default. Must be a value between 0 and 0777. Defaults to 0644. Directories within the path are not affected by this setting. This might be in conflict with other options that affect the file mode, like fsGroup, and the result can be other mode bits set.",
-					Optional:    true,
+					Type:         schema.TypeInt,
+					Description:  "Optional: mode bits to use on created files by default. Must be a value between 0 and 0777. Defaults to 0644. Directories within the path are not affected by this setting. This might be in conflict with other options that affect the file mode, like fsGroup, and the result can be other mode bits set.",
+					Optional:     true,
+					ValidateFunc: validateModeBits,
 				},
 				"name": {
 					Type:        schema.TypeString,

kubernetes/validators.go

@@ -165,6 +165,14 @@ func validateTerminationGracePeriodSeconds(value interface{}, key string) (ws []
 	return
 }
 
+func validateModeBits(value interface{}, key string) (ws []string, es []error) {
+	v := value.(int)
+	if v < 0 || v > 0777 {
+		es = append(es, fmt.Errorf("%s (%#o) expects octal notation (a value between 0 and 0777)", key))
+	}
+	return
+}
+
 func validateAttributeValueDoesNotContain(searchString string) schema.SchemaValidateFunc {
 	return func(v interface{}, k string) (ws []string, errors []error) {
 		input := v.(string)

kubernetes/validators_test.go

@@ -0,0 +1,27 @@
+package kubernetes
+
+import (
+	"testing"
+)
+
+func TestValidateModeBits(t *testing.T) {
+	validCases := []int{
+		0, 0001, 0644, 0777,
+	}
+	for _, mode := range validCases {
+		_, es := validateModeBits(mode, "mode")
+		if len(es) > 0 {
+			t.Fatalf("Expected %#o to be valid: %#v", mode, es)
+		}
+	}
+
+	invalidCases := []int{
+		-5, -1, 512, 777,
+	}
+	for _, mode := range invalidCases {
+		_, es := validateModeBits(mode, "mode")
+		if len(es) == 0 {
+			t.Fatalf("Expected %#o to be invalid", mode)
+		}
+	}
+}