Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource_kubernetes_env #1838

Merged
merged 32 commits into from Oct 11, 2022
Merged

Add resource_kubernetes_env #1838

merged 32 commits into from Oct 11, 2022

Conversation

BBBmau
Copy link
Contributor

@BBBmau BBBmau commented Sep 19, 2022

Description

Add resource_kubernetes_env for adding Environment Variables that are necessary for deployments

  • Add resource_kubernetes_env
  • Add Acceptance Tests
  • Add support for cronjobs

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

make testacc TESTARGS="-run TestAccKubernetesEnv_basic" 

TF_ACC=1 go test "/Users/mau/Dev/terraform-provider-kubernetes/kubernetes" -v -run TestAccKubernetesEnv_basic -timeout 3h
=== RUN   TestAccKubernetesEnv_basic
--- PASS: TestAccKubernetesEnv_basic (11.57s)
PASS
ok      github.com/hashicorp/terraform-provider-kubernetes/kubernetes   12.474s

Release Note

Release note for CHANGELOG:

Add resource_kubernetes_env.go

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Copy link
Contributor

@jrhouston jrhouston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good @BBBmau. Need to:

  • Add valueFrom to the schema for the env block
  • Documentation page for this resource
  • Add a changelog entry for this

kubernetes/resource_kubernetes_env.go Outdated Show resolved Hide resolved
kubernetes/resource_kubernetes_env.go Outdated Show resolved Hide resolved
kubernetes/resource_kubernetes_env.go Show resolved Hide resolved
Copy link
Contributor

@jrhouston jrhouston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BBBmau – nearly there 😃

kubernetes/resource_kubernetes_env.go Outdated Show resolved Hide resolved
kubernetes/resource_kubernetes_env.go Outdated Show resolved Hide resolved
kubernetes/resource_kubernetes_env.go Outdated Show resolved Hide resolved
kubernetes/resource_kubernetes_env.go Outdated Show resolved Hide resolved
kubernetes/resource_kubernetes_env.go Outdated Show resolved Hide resolved
kubernetes/structures_container.go Outdated Show resolved Hide resolved
website/docs/r/env.html.markdown Outdated Show resolved Hide resolved
website/docs/r/env.html.markdown Outdated Show resolved Hide resolved
website/docs/r/env.html.markdown Outdated Show resolved Hide resolved
kubernetes/structures_container.go Outdated Show resolved Hide resolved
Co-authored-by: John Houston <jrhouston@users.noreply.github.com>
website/docs/r/env.html.markdown Show resolved Hide resolved
website/docs/r/env.html.markdown Show resolved Hide resolved
@BBBmau BBBmau merged commit fd292ca into main Oct 11, 2022
@BBBmau BBBmau deleted the add-resource-kubernetes-env branch October 11, 2022 16:04
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants