Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource_kubernetes_env #1838

Merged
merged 32 commits into from
Oct 11, 2022
Merged
Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
de3d7e3
initial resource commit
BBBmau Sep 7, 2022
85bb707
add basic CRUD functions
BBBmau Sep 8, 2022
1a76443
add metadata block and create logic
BBBmau Sep 8, 2022
49307d9
add update function
BBBmau Sep 9, 2022
f8f1a17
add force attribute
BBBmau Sep 12, 2022
65377d0
add read function & getEnvs function
BBBmau Sep 12, 2022
74c3e71
add field_manager attribute
BBBmau Sep 13, 2022
89daf78
fix read function
BBBmau Sep 15, 2022
4292c4c
Add read function
BBBmau Sep 16, 2022
27f996c
Add Delete function
BBBmau Sep 16, 2022
d7239ab
draft createEnv function in test
BBBmau Sep 19, 2022
f308603
complete draft kubernetes_env_test.go
BBBmau Sep 21, 2022
0aa5df5
remove unnecessary getEnvs function
BBBmau Sep 22, 2022
dc14d6c
Finish Test for kubernetes_env_test
BBBmau Sep 23, 2022
71e7c4d
Add kubernetes_env docs
BBBmau Sep 28, 2022
0b21a80
add value_from attribute to tests
BBBmau Sep 28, 2022
af4c578
add value_from to schema
BBBmau Sep 28, 2022
4070ffa
Add Flatten Function
BBBmau Oct 7, 2022
fc7af0f
Update kubernetenv_test
BBBmau Oct 7, 2022
eb1e55b
Add changelog-entry
BBBmau Oct 7, 2022
dcbdab5
Format Env Docs
BBBmau Oct 7, 2022
87430fb
Fix test format
BBBmau Oct 7, 2022
ce66e39
Update website/docs/r/env.html.markdown
BBBmau Oct 8, 2022
984d8d1
Last Formatting Steps
BBBmau Oct 10, 2022
b54c414
Merge branch 'main' into add-resource-kubernetes-env
BBBmau Oct 10, 2022
62d6b2f
Update structures_container.go
BBBmau Oct 10, 2022
8c0634f
Add changelog-entry
BBBmau Oct 10, 2022
36e266a
Delete extra changelog
BBBmau Oct 10, 2022
5bf9594
Add missing info
BBBmau Oct 11, 2022
3608a2f
Add changelog-entry
BBBmau Oct 11, 2022
cf38f57
Merge branch 'main' into add-resource-kubernetes-env
BBBmau Oct 11, 2022
a7bb23c
Description Change
BBBmau Oct 11, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions kubernetes/provider.go
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,7 @@ func Provider() *schema.Provider {
"kubernetes_pod_v1": resourceKubernetesPod(),
"kubernetes_endpoints": resourceKubernetesEndpoints(),
"kubernetes_endpoints_v1": resourceKubernetesEndpoints(),
"kubernetes_env": resourceKubernetesEnv(),
"kubernetes_limit_range": resourceKubernetesLimitRange(),
"kubernetes_limit_range_v1": resourceKubernetesLimitRange(),
"kubernetes_persistent_volume": resourceKubernetesPersistentVolume(),
Expand Down
358 changes: 358 additions & 0 deletions kubernetes/resource_kubernetes_env.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,358 @@
package kubernetes

import (
"context"
"encoding/json"
"fmt"

"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
"github.com/hashicorp/terraform-provider-kubernetes/util"
"k8s.io/apimachinery/pkg/api/errors"
"k8s.io/apimachinery/pkg/api/meta"
"k8s.io/apimachinery/pkg/types"

v1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
k8sschema "k8s.io/apimachinery/pkg/runtime/schema"
"k8s.io/client-go/dynamic"
"k8s.io/client-go/restmapper"
)

// TODO:
/*
* add support for cronjobs
* add tests
*/
BBBmau marked this conversation as resolved.
Show resolved Hide resolved

func resourceKubernetesEnv() *schema.Resource {
return &schema.Resource{
CreateContext: resourceKubernetesEnvCreate,
ReadContext: resourceKubernetesEnvRead,
UpdateContext: resourceKubernetesEnvUpdate,
DeleteContext: resourceKubernetesEnvDelete,
Importer: &schema.ResourceImporter{
StateContext: schema.ImportStatePassthroughContext,
},
Schema: map[string]*schema.Schema{
"metadata": {
Type: schema.TypeList,
Required: true,
MaxItems: 1,
Elem: &schema.Resource{
Schema: map[string]*schema.Schema{
"name": {
Type: schema.TypeString,
Description: "The name of the resource.",
Required: true,
ForceNew: true,
},
"namespace": {
Type: schema.TypeString,
Description: "The namespace of the resource.",
Optional: true,
ForceNew: true,
},
},
},
},
"container": {
Type: schema.TypeString,
Description: "",
BBBmau marked this conversation as resolved.
Show resolved Hide resolved
Required: true,
},
"api_version": {
Type: schema.TypeString,
Description: "API Version of Field Manager",
Required: true,
},
"kind": {
Type: schema.TypeString,
Description: "Type of resource being used",
Required: true,
},
"env": {
Type: schema.TypeList,
Description: "Rule defining a set of permissions for the role",
Required: true,
Elem: &schema.Resource{
Schema: map[string]*schema.Schema{
"name": {
Type: schema.TypeString,
Required: true,
Description: "Name of the environment variable. Must be a C_IDENTIFIER",
},
"value": {
Type: schema.TypeString,
Optional: true,
Description: `Variable references $(VAR_NAME) are expanded using the previous defined environment variables in the container and any service environment variables. If a variable cannot be resolved, the reference in the input string will be unchanged. The $(VAR_NAME) syntax can be escaped with a double $$, ie: $$(VAR_NAME). Escaped references will never be expanded, regardless of whether the variable exists or not. Defaults to "".`,
},
jrhouston marked this conversation as resolved.
Show resolved Hide resolved
},
},
},
"force": {
Type: schema.TypeBool,
Description: "Force overwriting environments that were created or edited outside of Terraform.",
Optional: true,
},
"field_manager": {
Type: schema.TypeString,
Description: "Set the name of the field manager for the specified labels.",
Optional: true,
Default: defaultFieldManagerName,
},
},
}
}

func resourceKubernetesEnvCreate(ctx context.Context, d *schema.ResourceData, m interface{}) diag.Diagnostics {
metadata := expandMetadata(d.Get("metadata").([]interface{}))
d.SetId(buildIdWithVersionKind(metadata,
d.Get("api_version").(string),
d.Get("kind").(string)))
diag := resourceKubernetesEnvUpdate(ctx, d, m)
if diag.HasError() {
d.SetId("")
}
return diag
}

func resourceKubernetesEnvRead(ctx context.Context, d *schema.ResourceData, m interface{}) diag.Diagnostics {
conn, err := m.(KubeClientsets).DynamicClient()
if err != nil {
return diag.FromErr(err)
}

gvk, name, namespace, err := util.ParseResourceID(d.Id())
if err != nil {
return diag.FromErr(err)
}

// figure out which resource client to use
dc, err := m.(KubeClientsets).DiscoveryClient()
if err != nil {
return diag.FromErr(err)
}
agr, err := restmapper.GetAPIGroupResources(dc)
if err != nil {
return diag.FromErr(err)
}
restMapper := restmapper.NewDiscoveryRESTMapper(agr)
mapping, err := restMapper.RESTMapping(gvk.GroupKind(), gvk.Version)
if err != nil {
return diag.FromErr(err)
}

// determine if the resource is namespaced or not
var r dynamic.ResourceInterface
if mapping.Scope.Name() == meta.RESTScopeNameNamespace {
if namespace == "" {
namespace = "default"
}
r = conn.Resource(mapping.Resource).Namespace(namespace)
} else {
r = conn.Resource(mapping.Resource)
}

// get the resource environments
res, err := r.Get(ctx, name, v1.GetOptions{})
if err != nil {
if errors.IsNotFound(err) {
return diag.Diagnostics{{
Severity: diag.Warning,
Summary: "Resource deleted",
Detail: fmt.Sprintf("The underlying resource %q has been deleted. You should recreate the underlying resource, or remove it from your configuration.", name),
}}
}
return diag.FromErr(err)
}

// store names of environment variables into map
configuredEnvs := make(map[string]interface{})
envList := d.Get("env").([]interface{})
for _, e := range envList {
configuredEnvs[e.(map[string]interface{})["name"].(string)] = ""
}

// strip out envs not managed by Terraform
managedEnvs, err := getManagedEnvs(res.GetManagedFields(), defaultFieldManagerName, d)
if err != nil {
return diag.FromErr(err)
}
responseEnvs, err := getResponseEnvs(res, d.Get("container").(string))
if err != nil {
return diag.FromErr(err)
}

env := []interface{}{}
for _, e := range responseEnvs {
envName := e.(map[string]interface{})["name"].(string)
_, managed := managedEnvs[fmt.Sprintf(`k:{"name":%q}`, envName)]
_, configured := configuredEnvs[envName]
if !managed && !configured {
continue
}
env = append(env, e)
}
d.Set("env", env)
return nil
}

func getResponseEnvs(u *unstructured.Unstructured, containerName string) ([]interface{}, error) {
containers, _, _ := unstructured.NestedSlice(u.Object, "spec", "template", "spec", "containers")
for _, c := range containers {
container := c.(map[string]interface{})
if container["name"].(string) == containerName {
return container["env"].([]interface{}), nil
}
}
return nil, fmt.Errorf("could not find container with name %q", containerName)
}

// getManagedEnvs reads the field manager metadata to discover which environment variables we're managing
func getManagedEnvs(managedFields []v1.ManagedFieldsEntry, manager string, d *schema.ResourceData) (map[string]interface{}, error) {
var envs map[string]interface{}
for _, m := range managedFields {
if m.Manager != manager {
continue
}
var mm map[string]interface{}
err := json.Unmarshal(m.FieldsV1.Raw, &mm)
if err != nil {
return nil, err
}
spec := mm["f:spec"].(map[string]interface{})
template := spec["f:template"].(map[string]interface{})
templateSpec := template["f:spec"].(map[string]interface{})
containers := templateSpec["f:containers"].(map[string]interface{})
containerName := fmt.Sprintf(`k:{"name":%q}`, d.Get("container").(string))
k := containers[containerName].(map[string]interface{})
if e, ok := k["f:env"].(map[string]interface{}); ok {
envs = e
}
}
return envs, nil
}

func resourceKubernetesEnvUpdate(ctx context.Context, d *schema.ResourceData, m interface{}) diag.Diagnostics {
conn, err := m.(KubeClientsets).DynamicClient()
if err != nil {
return diag.FromErr(err)
}

apiVersion := d.Get("api_version").(string)
kind := d.Get("kind").(string)
metadata := expandMetadata(d.Get("metadata").([]interface{}))
name := metadata.GetName()
namespace := metadata.GetNamespace()

// figure out which resource client to use
dc, err := m.(KubeClientsets).DiscoveryClient()
if err != nil {
return diag.FromErr(err)
}
agr, err := restmapper.GetAPIGroupResources(dc)
if err != nil {
return diag.FromErr(err)
}
restMapper := restmapper.NewDiscoveryRESTMapper(agr)
gv, err := k8sschema.ParseGroupVersion(apiVersion)
if err != nil {
return diag.FromErr(err)
}
mapping, err := restMapper.RESTMapping(gv.WithKind(kind).GroupKind(), gv.Version)
if err != nil {
return diag.FromErr(err)
}

// determine if the resource is namespaced or not
var r dynamic.ResourceInterface
namespacedResource := mapping.Scope.Name() == meta.RESTScopeNameNamespace
if namespacedResource {
if namespace == "" {
namespace = "default"
}
r = conn.Resource(mapping.Resource).Namespace(namespace)
} else {
r = conn.Resource(mapping.Resource)
}

// check the resource exists before we try and patch it
_, err = r.Get(ctx, name, v1.GetOptions{})
if err != nil {
if d.Id() == "" {
// if we are deleting then there is nothing to do
// if the resource is gone
return nil
}
return diag.Errorf("The resource %q does not exist", name)
}

patchmeta := map[string]interface{}{
"name": name,
}
if namespacedResource {
patchmeta["namespace"] = namespace
}

env := d.Get("env")
if d.Id() == "" {
env = []map[string]interface{}{}
}

patchobj := map[string]interface{}{
"apiVersion": apiVersion,
"kind": kind,
"metadata": patchmeta,
"spec": map[string]interface{}{
"template": map[string]interface{}{
"spec": map[string]interface{}{
"containers": []interface{}{
map[string]interface{}{
"name": d.Get("container").(string),
"env": env,
},
},
},
},
},
}

patch := unstructured.Unstructured{}
patch.Object = patchobj
patchbytes, err := patch.MarshalJSON()
if err != nil {
return diag.FromErr(err)
}
_, err = r.Patch(ctx,
name,
types.ApplyPatchType,
patchbytes,
v1.PatchOptions{
FieldManager: d.Get("field_manager").(string),
Force: ptrToBool(d.Get("force").(bool)),
},
)
if err != nil {
if errors.IsConflict(err) {
return diag.Diagnostics{{
Severity: diag.Error,
Summary: "Field manager conflict",
Detail: fmt.Sprintf(`Another client is managing a field Terraform tried to update. Set "force" to true to override: %v`, err),
}}
}
return diag.FromErr(err)
}

if d.Id() == "" {
// don't try to read if we're deleting
return nil
}

return resourceKubernetesEnvRead(ctx, d, m)
}

func resourceKubernetesEnvDelete(ctx context.Context, d *schema.ResourceData, m interface{}) diag.Diagnostics {
d.SetId("")
return resourceKubernetesEnvUpdate(ctx, d, m)
}