-
Notifications
You must be signed in to change notification settings - Fork 968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support empty TLS blocks in ingress_v1 #2344
Support empty TLS blocks in ingress_v1 #2344
Conversation
07dc55e
to
4d5e04a
Compare
Ready for review |
4d5e04a
to
b9c3498
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing this!
There are a few things I would like to ask you to fix before we merge your PR:
-
Could you please make the same change for the
kubernetes_ingress
resource too? -
Please add the following change file
.changelog/2344.txt
:
```release-note:bug
`resource/kubernetes_ingress`: Fix an issue where the empty `tls` attribute in the configuration does not generate the corresponding Ingress object without any TLS configuration.
```
```release-note:bug
`resource/kubernetes_ingress_v1`: Fix an issue where the empty `tls` attribute in the configuration does not generate the corresponding Ingress object without any TLS configuration.
```
- Run
make tests-lint-fix
to fix the TF code used in tests.
I will keep an eye on this PR.
Thank you!
b9c3498
to
449e95f
Compare
449e95f
to
6a8f538
Compare
@arybolovlev Thanks for the review! I have pushed those changes your requested. |
The kind acceptance tests appear to be attempting to run without |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for addressing this, @andremarianiello!
That is ok, this is due to some GH limitations. Thank you for addressing this problem! |
@arybolovlev Thank you for your responsiveness! I am trying to figure out when this fix will be released. Do you have a published release schedule or release criteria? |
We don't have a schedule for this provider but looking at the number of fixes we currently have unreleased, I think we will issue a new release this or next week. |
Awesome! Can't wait 👍 |
Description
Fix an issue where the empty
tls
attribute in the configuration does not generate the corresponding Ingress object without any TLS configuration.The following TF code:
Should produce the following Ingress object:
Acceptance tests
Output from acceptance testing:
Release Note
Release note for CHANGELOG:
References
Fix: #2343
Community Note