bugfix: introduce filter for flattenPodSpec to control tolerations #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you start a pod natively, k8s may add tolerations automatically that you did not define. There is already a filter in the flattenPodSpec that filters these out, but if you start it as part of a deployment/replicaset/daemonset, you might want to use similar tolerations and don't want to get in a perpetual diff (where state refresh ignores your toleration in deployments just like it would with native pods). This is not a silver bullet, but unblocked me at my work, in the future maybe a more robust solution (e.g. there is not tellign that you will use this prefix of tolerations in natively started pods, making the problem I have with deployments appear there as well)
|
|
|
Any chance to get this merged? |
|
Yes please, let this merge happen if there's no problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If you start a pod natively, k8s may add tolerations automatically that
you did not define. There is already a filter in the flattenPodSpec that
filters these out, but if you start it as part of a
deployment/replicaset/daemonset, you might want to use similar
tolerations and don't want to get in a perpetual diff (where state
refresh ignores your toleration in deployments just like it would with
native pods).
This is not a silver bullet, but unblocked me at my work and will possibly unblock many others, as these taint tolerations are used by modules in the registry including https://registry.terraform.io/modules/spotinst/ocean-controller/spotinst/0.5.0 which connects spot.io managed workers to EKS.
Acceptance tests
Output from acceptance testing:
Release Note
Release note for CHANGELOG:
References
fixes issue: #955
slightly related: #978
Community Note