Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix perpetual diff in StatefulSet #1097

Merged
merged 1 commit into from Dec 18, 2020
Merged

Conversation

dak1n1
Copy link
Contributor

@dak1n1 dak1n1 commented Dec 17, 2020

Description

Fixes #1088

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

The acceptance test for this one is in #1074, but it passed a manual test using the reproducer from the bug:

kubernetes_stateful_set.test: Creating...
kubernetes_stateful_set.test: Creation complete after 8s [id=default/test]

Apply complete! Resources: 1 added, 0 changed, 0 destroyed.

$ terraform plan
kubernetes_stateful_set.test: Refreshing state... [id=default/test]

No changes. Infrastructure is up-to-date.

Release Note

Release note for CHANGELOG:

Fix perpetual diff in StatefulSet when update_strategy is not specified (#1088)

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@ghost ghost added the size/XS label Dec 17, 2020
@dak1n1 dak1n1 requested a review from a team December 17, 2020 00:25
Copy link
Contributor

@jrhouston jrhouston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🤠 🚀

@dak1n1 dak1n1 merged commit 0692409 into hashicorp:master Dec 18, 2020
@ghost
Copy link

ghost commented Jan 18, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StatefulSet is updated on each apply when UpdateStrategy is not specified
2 participants