Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/deployment - remove computed from volume_mount #1246

Merged

Conversation

DrFaust92
Copy link
Contributor

@DrFaust92 DrFaust92 commented Apr 17, 2021

Description

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccKubernetesDeployment_'
--- PASS: TestAccKubernetesDeployment_minimal (7.88s)
--- PASS: TestAccKubernetesDeployment_basic (18.10s)
--- PASS: TestAccKubernetesDeployment_initContainerForceNew (34.08s)
--- PASS: TestAccKubernetesDeployment_generatedName (6.41s)
--- PASS: TestAccKubernetesDeployment_with_security_context (3.89s)
--- PASS: TestAccKubernetesDeployment_with_security_context_run_as_group (6.37s)
--- PASS: TestAccKubernetesDeployment_with_security_context_sysctl (6.22s)
--- PASS: TestAccKubernetesDeployment_with_tolerations (5.99s)
--- PASS: TestAccKubernetesDeployment_with_tolerations_unset_toleration_seconds (6.11s)
--- PASS: TestAccKubernetesDeployment_with_container_liveness_probe_using_exec (6.20s)
--- PASS: TestAccKubernetesDeployment_with_container_liveness_probe_using_http_get (6.10s)
--- PASS: TestAccKubernetesDeployment_with_container_liveness_probe_using_tcp (5.97s)
--- PASS: TestAccKubernetesDeployment_with_container_lifecycle (5.91s)
--- PASS: TestAccKubernetesDeployment_with_container_security_context (5.82s)
--- PASS: TestAccKubernetesDeployment_with_container_security_context_run_as_group (6.02s)
--- PASS: TestAccKubernetesDeployment_with_volume_mount (8.48s)
--- PASS: TestAccKubernetesDeployment_ForceNew (13.80s)
--- PASS: TestAccKubernetesDeployment_with_resource_requirements (2.62s)
--- PASS: TestAccKubernetesDeployment_with_empty_dir_volume (7.98s)
--- PASS: TestAccKubernetesDeployment_with_deployment_strategy_rollingupdate (3.97s)
--- PASS: TestAccKubernetesDeployment_with_share_process_namespace (6.15s)
--- PASS: TestAccKubernetesDeployment_no_rollout_wait (2.91s)
--- PASS: TestAccKubernetesDeployment_with_deployment_strategy_rollingupdate_max_surge_30perc_max_unavailable_40perc (18.05s)
--- PASS: TestAccKubernetesDeployment_with_deployment_strategy_rollingupdate_max_surge_200perc_max_unavailable_0perc (4.18s)
--- PASS: TestAccKubernetesDeployment_with_deployment_strategy_rollingupdate_max_surge_0_max_unavailable_1 (4.08s)
--- PASS: TestAccKubernetesDeployment_with_deployment_strategy_rollingupdate_max_surge_1_max_unavailable_0 (3.91s)
--- PASS: TestAccKubernetesDeployment_with_deployment_strategy_rollingupdate_max_surge_1_max_unavailable_2 (5.80s)
--- PASS: TestAccKubernetesDeployment_with_deployment_strategy_recreate (3.75s)
--- PASS: TestAccKubernetesDeployment_with_host_aliases (5.72s)
--- PASS: TestAccKubernetesDeployment_regression (211.33s)
--- PASS: TestAccKubernetesDeployment_with_resource_field_selector (8.83s)
--- PASS: TestAccKubernetesDeployment_config_with_automount_service_account_token (5.98s)

Release Note

Release note for CHANGELOG:

resource_kubernets_deployment - allow removing volume mount

References

Closes #870

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@ghost ghost added the size/M label Apr 17, 2021
@DrFaust92 DrFaust92 marked this pull request as ready for review April 17, 2021 16:50
@dak1n1 dak1n1 added the acknowledged Issue has undergone initial review and is in our work queue. label Apr 26, 2021
@jrhouston jrhouston self-assigned this May 6, 2021
@jrhouston jrhouston merged commit e338cc8 into hashicorp:main May 13, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2021
@DrFaust92 DrFaust92 deleted the r/deployment_remove_volume_mount branch June 13, 2021 05:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
acknowledged Issue has undergone initial review and is in our work queue. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot remove volume_mount
3 participants