Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/service - add validations + import checks for all tests #1273

Merged
merged 2 commits into from May 18, 2021

Conversation

DrFaust92
Copy link
Contributor

Description

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccKubernetesService_'
--- PASS: TestAccKubernetesService_basic (6.44s)
--- PASS: TestAccKubernetesService_nodePort (4.89s)
--- PASS: TestAccKubernetesService_externalName (2.83s)
--- PASS: TestAccKubernetesService_externalName_toClusterIp (6.58s)
--- PASS: TestAccKubernetesService_generatedName (2.84s)
--- PASS: TestAccKubernetesService_regression (201.65s)

Release Note

Release note for CHANGELOG:

resource_kubernetes_service - add plan time validations for `spec.cluster_ip`, `spec.external_ips`, `spec.load_balancer_ip`,`spec.load_balancer_source_ranges`, `spec.port.node_port`, `spec.port.port`, `spec.health_check_node_port`
...

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@ghost ghost added size/L labels May 17, 2021
@ghost ghost added size/M and removed size/L labels May 17, 2021
@jrhouston jrhouston self-assigned this May 18, 2021
Copy link
Contributor

@jrhouston jrhouston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tidying this up @DrFaust92 😄

@jrhouston jrhouston merged commit 8ae158a into hashicorp:main May 18, 2021
@benoittoulme
Copy link

benoittoulme commented Jun 3, 2021

If cluster_ip can be set to None, then
ValidateFunc: validation.IsIPAddress
does not work I believe.
( This breaks my deployment ;) )

@arohter
Copy link

arohter commented Jun 3, 2021

Error: expected spec.0.cluster_ip to contain a valid IP, got: None

... in resource "kubernetes_service" "svc":
        cluster_ip = "None"

@jrhouston
Copy link
Contributor

@DrFaust92 just FYI: #1292

@github-actions
Copy link

github-actions bot commented Jul 4, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants