New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for storage/v1 #1457
Conversation
@@ -169,54 +169,81 @@ func Provider() *schema.Provider { | |||
}, | |||
|
|||
DataSourcesMap: map[string]*schema.Resource{ | |||
"kubernetes_all_namespaces": dataSourceKubernetesAllNamespaces(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've sorted this mapping into groups in advance of a more thorough re-organization of the code I have planned here.
PreCheck: func() { testAccPreCheck(t) }, | ||
PreCheck: func() { | ||
testAccPreCheck(t) | ||
skipIfClusterVersionGreaterThan(t, "v1.21.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The skip was actually broken and always returning false as it needs to happen after the provider is initialized by testAccPreCheck()
.
@@ -0,0 +1,212 @@ | |||
package kubernetes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty much all the code below except for the deprecation warning is a straight copy of the existing resource, but with the API function changed from V1Beta1 to V1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Tested, it works nicely.
One tiny spelling omission in the deprecation message.
Co-authored-by: Alex Somesan <alex.somesan@gmail.com>
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR adds support for storage/v1 – the only resource affected by this change is
kubernetes_csi_driver
. This change adds akubernetes_csi_driver_v1
and adds a deprecation warning tokubernetes_csi_driver
. There are no fields added or removed in v1 so the schema remains the same.Acceptance tests
Output from acceptance testing:
v1.22
v1.21
Release Note
Release note for CHANGELOG:
References
Community Note