Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix identification of 'int-or-string' type attributes #1640

Merged
merged 2 commits into from Apr 22, 2022

Conversation

alexsomesan
Copy link
Member

@alexsomesan alexsomesan commented Mar 14, 2022

Description

int-or-string types can also be defined by aggregated APIs, as 3rd party types.
Both built-in and 3rd party int-or-string types have a signature value of int-or-string in the format attribute.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Release Note

Release note for CHANGELOG:

...

References

Fixes #1627

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@alexsomesan alexsomesan marked this pull request as ready for review March 14, 2022 18:15
@alexsomesan alexsomesan merged commit 1c6f968 into main Apr 22, 2022
@alexsomesan alexsomesan deleted the fix-int-or-string branch April 22, 2022 11:56
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kubernetes_manifest: Conversion from Unstructured to tftypes.Value failed
2 participants