Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore service account volumes with kube-api-access prefix #1663

Merged
merged 1 commit into from Mar 30, 2022

Conversation

vin01
Copy link
Contributor

@vin01 vin01 commented Mar 26, 2022

This is already fixed for container resources in ef15ac8. Eventually it might make sense to just use this prefix for filtering as it is updated in kubernetes itself: kubernetes/kubernetes@1244ee6

@hashicorp-cla
Copy link

hashicorp-cla commented Mar 26, 2022

CLA assistant check
All committers have signed the CLA.

This is already fixed for `container` resources in hashicorp@ef15ac8. Eventually it might make sense to just use this prefix for filtering as it is updated in kubernetes itself: kubernetes/kubernetes@1244ee6
@jrhouston
Copy link
Contributor

Eventually it might make sense to just use this prefix for filtering as it is updated in kubernetes itself: kubernetes/kubernetes@1244ee6

Agreed but for now we still have to support users on older cluster versions – so we'll need to wait a few versions before we can remove the old prefix.

Copy link
Contributor

@jrhouston jrhouston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix @vin01

@jrhouston jrhouston merged commit ace84cf into hashicorp:main Mar 30, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants