New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pod metadata to replication controller spec template #193
Merged
alexsomesan
merged 19 commits into
hashicorp:master
from
pdecat:fix-replication-controller-metadata
Jan 11, 2019
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
b637863
WIP (to rework): Fix replication controller metadata
pdecat 43b0220
Revert acceptance tests timeout
pdecat b89dbbd
Use dynamic default func to keep defaults when item is not computed i…
pdecat 9509aca
Do not merge values from replication controller selector with labels …
pdecat b63a7ab
Fix replication controller template flattener & expander functions to…
pdecat 40aa209
Rename existing replication controller acceptance tests as deprecated…
pdecat aeae5f7
Prevent mixing deprecated spec fields with new ones to avoid complex …
pdecat f94b7e4
Do not try to merge deprecated replication controller spec fields wit…
pdecat 1925ae5
Add labels and annotations to new replication controller template met…
pdecat e94e5be
Refactor deprecated fields usage detection
pdecat bdbc47f
Fix TestAccKubernetesReplicationController_deprecated_generatedName t…
pdecat 3e3c778
TODO: Add conditional logic that returns an error if both the old and…
pdecat 8a52669
Put back d.GetOkExists() (but deprecated import test cases fail just …
pdecat feafef1
Cleanup replication controller spec expander function
pdecat d3b9f4a
Disable state verification for import test cases with usage of deprec…
pdecat a0bb3a8
Format inline HCL in ACC tests with github.com/katbyte/terrafmt
pdecat 7568f45
Return an error if new spec fields are used but no metadata is define…
pdecat a273d9d
Update documentation of replication controller for #193
pdecat 9532a33
Update changelog for #193
pdecat File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
887 changes: 887 additions & 0 deletions
887
kubernetes/resource_kubernetes_replication_controller_deprecated_test.go
Large diffs are not rendered by default.
Oops, something went wrong.
516 changes: 320 additions & 196 deletions
516
kubernetes/resource_kubernetes_replication_controller_test.go
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice transitive solution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad you like it :)
An alternative may have been to prevent combining deprecated fields with new ones in the same configuration.