Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support optional on env valueFrom for secret key/configmap key #824

Merged
merged 1 commit into from
Jun 23, 2020

Conversation

mbarrien
Copy link
Contributor

Description

Adds ability for secret key and config map key refs used in value_from for environment variables to be optional. Fixes documentation typos. Adds structures_container unit tests.

Picks back up where #295 left off.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch? (If so, please include the test log in a gist)

References

Closes #240. Closes #531.

==> Checking that code complies with gofmt requirements...
go test "./kubernetes" || exit 1
ok  	github.com/terraform-providers/terraform-provider-kubernetes/kubernetes	5.776s
echo "./kubernetes" | \
		xargs -t -n4 go test  -timeout=30s -parallel=4
go test -timeout=30s -parallel=4 ./kubernetes
ok  	github.com/terraform-providers/terraform-provider-kubernetes/kubernetes	3.231s

Copy link
Contributor

@dak1n1 dak1n1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the acceptance tests on this, reviewed the docs and compared against the Kubernetes API docs, and compiled to try the new code out manually with a couple scenarios. It works great! Thanks for your work on this. The tests are a really nice addition too.

@dak1n1 dak1n1 merged commit 30efbd2 into hashicorp:master Jun 23, 2020
@ghost
Copy link

ghost commented Jul 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 24, 2020
@mbarrien mbarrien deleted the secretcmenv-optional branch January 20, 2021 17:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants