fix: add termination_message_policy to container schema (closes #442)

[AeroNotix]

Description

Adds termination_message_policy to the container schema.

References

#442

[AeroNotix]

@radeksimko please could I have a review on this PR.

[AeroNotix]

@alexsomesan @pdecat @appilon any chance of a review?

[pdecat]

Looks good, documentation for this should be added, see https://github.com/terraform-providers/terraform-provider-kubernetes/blame/v1.11.3/website/docs/r/pod.html.markdown#L338

Also, it's always nice to have acceptance tests for new attributes.

[AeroNotix]

@pdecat where do the tests go?

[pdecat]

You could probably introduce new test functions TestAccKubernetesPod_termination_message_policy_* to exercise the possible combinations (not set, set to File and set to FallbackToLogsOnError, like https://github.com/terraform-providers/terraform-provider-kubernetes/blob/v1.11.3/kubernetes/resource_kubernetes_pod_test.go#L294-L319

[AeroNotix]

@pdecat added tests, didn't run them - hoping your CI runs them.

[AeroNotix]

@pdecat fixed up tests, can you take a look please.

[AeroNotix]

@pdecat ping? Apologies! Would like to get this merged if possible.

[pdecat]

Hi @AeroNotix,

looks good overall, I left an question whether the new field should be computed or have a default. I'd like input from the provider maintainers here.

In addition to tests with pods, it would be nice to also have a multi-step test in the context of a deployment to validate updates of the field, e.g. step 0 no value, step 1 File, step 2 FallbackToLogsOnError.

The acceptance tests are currently failing because of a trivial typo I believe:

# make testacc TEST=./kubernetes TESTARGS='-run=TestAccKubernetesPod_termination_.* -count=1'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./kubernetes -v -run=TestAccKubernetesPod_termination_.* -count=1 -timeout 120m
=== RUN   TestAccKubernetesPod_termination_message_policy_default
--- PASS: TestAccKubernetesPod_termination_message_policy_default (16.25s)
=== RUN   TestAccKubernetesPod_termination_message_policy_override_as_file
--- PASS: TestAccKubernetesPod_termination_message_policy_override_as_file (6.85s)
=== RUN   TestAccKubernetesPod_termination_message_policy_override_as_fallback_to_logs_on_err
    TestAccKubernetesPod_termination_message_policy_override_as_fallback_to_logs_on_err: testing.go:654: Step 0 error: Check failed: 1 error occurred:
                * Check 2/2 error: kubernetes_pod.test: Attribute 'spec.0.container.0.termination_message_policy' expected "FallBackToLogsOnErr", got "FallbackToLogsOnError"


--- FAIL: TestAccKubernetesPod_termination_message_policy_override_as_fallback_to_logs_on_err (6.16s)
FAIL
FAIL    github.com/terraform-providers/terraform-provider-kubernetes/kubernetes 29.318s
FAIL
make: *** [GNUmakefile:17: testacc] Error 1

Running the acceptance tests locally with minikube is as easy as:

# minikube start
# export KUBE_CTX=minikube
# make testacc TEST=./kubernetes TESTARGS='-run=TestAccKubernetesPod_termination_.* -count=1'

Note: I'm just a contributor with no merge power here.

[AeroNotix]

@aareet please can this be looked at

[aareet]

@AeroNotix thank you for this PR. It's already in our queue for review - we appreciate your patience. FAQ

[AeroNotix]

Maybe you need to give active members of the community such as @pdecat commit access, lighten your heavy workload.

[AeroNotix]

@jrhouston @pdecat moved over to setting the field as computed.

[aareet]

LGTM

❯ TESTARGS="-run '^TestAccKubernetesPod_termination_message_policy'" make testacc
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test "./kubernetes" -v -run '^TestAccKubernetesPod_termination_message_policy' -timeout 120m
=== RUN   TestAccKubernetesPod_termination_message_policy_default
--- PASS: TestAccKubernetesPod_termination_message_policy_default (15.33s)
=== RUN   TestAccKubernetesPod_termination_message_policy_override_as_file
--- PASS: TestAccKubernetesPod_termination_message_policy_override_as_file (8.04s)
=== RUN   TestAccKubernetesPod_termination_message_policy_override_as_fallback_to_logs_on_err
--- PASS: TestAccKubernetesPod_termination_message_policy_override_as_fallback_to_logs_on_err (18.04s)
PASS
ok  	github.com/terraform-providers/terraform-provider-kubernetes/kubernetes	43.415s

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!