Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pod security policies #861

Merged
merged 4 commits into from
Jun 25, 2020
Merged

Conversation

discreet
Copy link
Contributor

The below PR has been open since September 20, 2019. The author has life events going on that do not allow them to finish the work. This PR is built off of their fork and branch and makes an attempt to resolve the blocking merge conflicts.

#624

@hashicorp-cla
Copy link

hashicorp-cla commented Jun 11, 2020

CLA assistant check
All committers have signed the CLA.

add web documentation for kubernetes_pod_security_policy

rename variable binding => psp (copy-paste error)

Update import paths for provider SDK packages

go mod tidy

go mod vendor

Signed-off-by: Christopher Pisano <cpisano@morningconsult.com>
@jrhouston jrhouston self-assigned this Jun 16, 2020
@jrhouston jrhouston added the acknowledged Issue has undergone initial review and is in our work queue. label Jun 16, 2020
kubernetes/provider.go Outdated Show resolved Hide resolved
Copy link
Contributor

@jrhouston jrhouston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up @discreet! I've requested a few changes before we can merge.

@jrhouston jrhouston assigned jrhouston and unassigned jrhouston Jun 23, 2020
@discreet discreet requested a review from jrhouston June 24, 2020 14:17
Copy link
Contributor

@jrhouston jrhouston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making those changes, couple more typos to fix

website/docs/r/pod_security_policy.html.markdown Outdated Show resolved Hide resolved
website/docs/r/pod_security_policy.html.markdown Outdated Show resolved Hide resolved
website/docs/r/pod_security_policy.html.markdown Outdated Show resolved Hide resolved
@discreet discreet requested a review from jrhouston June 24, 2020 14:33
Copy link
Contributor

@jrhouston jrhouston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple more changes, trying to build raised some errors.

kubernetes/resource_kubernetes_pod_security_policy.go Outdated Show resolved Hide resolved
kubernetes/resource_kubernetes_pod_security_policy_test.go Outdated Show resolved Hide resolved
@discreet discreet force-pushed the pod-security-policies branch 2 times, most recently from 30afb51 to baa8d7b Compare June 24, 2020 19:52
Copy link
Contributor

@jrhouston jrhouston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed a few references to extensions/v1beta1

kubernetes/resource_kubernetes_pod_security_policy_test.go Outdated Show resolved Hide resolved
kubernetes/resource_kubernetes_pod_security_policy.go Outdated Show resolved Hide resolved
kubernetes/resource_kubernetes_pod_security_policy.go Outdated Show resolved Hide resolved
kubernetes/resource_kubernetes_pod_security_policy.go Outdated Show resolved Hide resolved
Copy link
Contributor

@jrhouston jrhouston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Thanks for contributing @discreet and @andyroyle

@discreet
Copy link
Contributor Author

Wooo glad this is finally ready. Really appreciate your patience with me @jrhouston. This is going to be a very helpful and very needed feature for me to better manage my company's EKS clusters.

@ghost
Copy link

ghost commented Jul 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
acknowledged Issue has undergone initial review and is in our work queue. dependencies documentation size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants