r/deployment - wait for deployment to delete

[DrFaust92]

Description

Add wait logic for deployment resource to properly delete (similar to other resources like CSI Driver and stateful set)

Acceptance tests

• Have you added an acceptance test for the functionality being added?
• Have you run the acceptance tests on this branch? (If so, please include the test log in a gist)

--- PASS: TestAccKubernetesDeployment_basic (91.68s)
--- PASS: TestAccKubernetesDeployment_with_share_process_namespace (17.99s)
--- PASS: TestAccKubernetesDeployment_no_rollout_wait (19.82s)
--- PASS: TestAccKubernetesDeployment_with_deployment_strategy_rollingupdate_max_surge_30perc_max_unavailable_40perc (19.20s)
--- PASS: TestAccKubernetesDeployment_with_deployment_strategy_rollingupdate_max_surge_200perc_max_unavailable_0perc (21.52s)
--- PASS: TestAccKubernetesDeployment_with_deployment_strategy_rollingupdate_max_surge_0_max_unavailable_1 (31.07s)
--- PASS: TestAccKubernetesDeployment_with_deployment_strategy_rollingupdate_max_surge_1_max_unavailable_0 (18.30s)
--- PASS: TestAccKubernetesDeployment_with_deployment_strategy_rollingupdate_max_surge_1_max_unavailable_2 (17.79s)
--- PASS: TestAccKubernetesDeployment_with_deployment_strategy_recreate (17.67s)
--- PASS: TestAccKubernetesDeployment_with_host_aliases (24.91s)
--- PASS: TestAccKubernetesDeployment_config_with_automount_service_account_token (31.38s)

References

DrFaust92/terraform-kubernetes-ebs-csi-driver#2

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

[eddy-curv]

looks promising, can it be released in 1.12.1?

[dak1n1]

Perfect! Thanks for making this. It is a much-needed feature.

[hcharley]

Does anyone know if 1.12.1 is being held, or does it just need to be tagged and released?

[aareet]

@Charlex we're working to tag/release this week

[hcharley]

@Charlex we're working to tag/release this week

Thanks @aareet. Looking forward to the days where I don't have to apply plans twice for a deployment :)

[hcharley]

👀

https://github.com/hashicorp/terraform-provider-kubernetes/releases/tag/v1.13.0

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!