Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Sysctl in pod spec #938

Merged
merged 2 commits into from
Aug 20, 2020
Merged

Conversation

DrFaust92
Copy link
Contributor

Description

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch? (If so, please include the test log in a gist)
--- PASS: TestAccKubernetesDeployment_with_security_context (20.18s)
--- PASS: TestAccKubernetesDeployment_with_security_context_run_as_group (14.52s)
--- PASS: TestAccKubernetesDeployment_with_security_context_sysctl (13.65s)

References

Closes #927

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Copy link
Contributor

@dak1n1 dak1n1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! This works in my manual testing and acceptance tests. Thanks for all the good work!

@dak1n1 dak1n1 merged commit d079ee2 into hashicorp:master Aug 20, 2020
@phlegx
Copy link

phlegx commented Aug 21, 2020

Awesome. Totally awesome thanks a lot!!

@ghost
Copy link

ghost commented Oct 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 10, 2020
@DrFaust92 DrFaust92 deleted the sysctl_pod_spec branch April 15, 2021 12:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support sysctl argument in security_context section for the kubernetes_deployment resource
3 participants