r/deployment - init container in deployment recreates

[DrFaust92]

Description

Acceptance tests

• Have you added an acceptance test for the functionality being added?
• Have you run the acceptance tests on this branch? (If so, please include the test log in a gist)

--- PASS: TestAccKubernetesDeployment_initContainer (74.29s)

Kind of cheated here instead of properly refactoring.

References

Closes #951

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

[DrFaust92]

@jrhouston, open to a better check to see that its not recreated. i just looked at the logs

[jrhouston]

I kind of want to rework this function to have the logic be a bit easier to understand, perhaps an isTemplate variable so we know that the schema is embedded within the template of a deployment, statefulset, or daemonset.

For the moment I think you can actually just remove the line with ForceNew in it because there is a loop at the bottom of the function that will set everything to ForceNew if isUpdatable is set to false:

terraform-provider-kubernetes/kubernetes/schema_pod_spec.go

Lines 359 to 370 in 1fec9c2

	if !isUpdatable {
	for k := range s {
	if k == "active_deadline_seconds" {
	// This field is always updatable
	continue
	}
	if k == "container" {
	// Some fields are always updatable
	continue
	}
	s[k].ForceNew = true
	}

[DrFaust92]

@jrhouston, add init_container to the !isUpdatable block as you proposed.
Having issues with local K8s to test this though

[yzargari]

This is also happening in daemonset resources. This PR doesn't happen to take care of that by any chance, does it?

[dak1n1]

@yzargari thanks for letting us know! That's really useful information. I'll start working on a new PR that will fix them both, just so that we can move forward quickly with this. @DrFaust92 I'll make sure you get credit too, since there is valuable work in this PR. I just want to do a bunch of testing today to get this change in and it's faster than coordinating.

[DrFaust92]

Closing in favor of #1074 @dak1n1 let me know if i can help.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!