Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sensitive option to local_file to suppress output in plan #101

Merged
merged 4 commits into from Mar 1, 2022

Conversation

jhancock93
Copy link
Contributor

@jhancock93 jhancock93 commented Feb 14, 2022

Add sensitive boolean attribute to data source local_file to output to sensitive_content field instead of content field.

Closes #36
Closes #64

@jhancock93 jhancock93 requested a review from a team as a code owner February 14, 2022 18:56
@hashicorp-cla
Copy link

hashicorp-cla commented Feb 14, 2022

CLA assistant check
All committers have signed the CLA.

@jhancock93
Copy link
Contributor Author

@teamterraform, Any update on this? I have need of this because control-characters that show up in the output can break Jenkins executions of the terraform...

Copy link
Contributor

@detro detro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @jhancock93, thanks for this.

So, this is great, and I left some comments inline.
NOTE: the website documentation needs updating (i.e. this). The update should reflect the new attributes, as well as an example usage. Please also make sure the doc explains the "mutually exclusive" nature of setting sensitive = true

internal/provider/data_source_local_file.go Outdated Show resolved Hide resolved
internal/provider/data_source_local_file.go Outdated Show resolved Hide resolved
@jhancock93
Copy link
Contributor Author

Thanks @detro. I have updated the documentation as suggested.

Copy link
Contributor

@detro detro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is progressing great. Just left a few more comments, but we are pretty much looking at the runway for a smooth landing :)

internal/provider/data_source_local_file.go Show resolved Hide resolved
website/docs/d/file.html.md Outdated Show resolved Hide resolved
website/docs/d/file.html.md Outdated Show resolved Hide resolved
website/docs/d/file.html.md Outdated Show resolved Hide resolved
website/docs/d/file.html.md Outdated Show resolved Hide resolved
website/docs/d/file.html.md Outdated Show resolved Hide resolved
website/docs/d/file.html.md Outdated Show resolved Hide resolved
jhancock93 and others added 2 commits February 23, 2022 21:02
Committing suggested documentation changes.

Co-authored-by: Ivan De Marino <ivan.de.marino@gmail.com>
@jhancock93
Copy link
Contributor Author

@detro, I think I have addressed all your feedback. Let me know if anything else is needed before merging! Thank you!

@jhancock93 jhancock93 requested a review from detro March 1, 2022 13:27
Copy link
Contributor

@detro detro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you so much for this contribution

@detro detro merged commit 8ef0585 into hashicorp:main Mar 1, 2022
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants