Implement managing sentinel policies. #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paddycarver
added a commit
that referenced
this pull request
Feb 20, 2018
Add a `policy_override` field to `nomad_job` to override any soft-mandatory Sentinel policies that may fail during the job registration. Depends on #27.
Add a nomad_sentinel_policy resource that manages a Sentinel policy for the Nomad cluster.
paddycarver
force-pushed
the
paddy_sentinel
branch
from
9f1d4ec
to
e91e31e
Compare
I don't know why half of this is necessary, but govendor says it is. I'll do an audit as a separate PR to fix our vendoring situation, because this is nuts.
paultyng
approved these changes
Mar 23, 2018
paddycarver
added a commit
that referenced
this pull request
Mar 23, 2018
Add a `policy_override` field to `nomad_job` to override any soft-mandatory Sentinel policies that may fail during the job registration. Depends on #27.
|
Does this feature also include running sentinel policy tests on |
|
No, this feature is solely for registering the policies within Nomad. Unfortunately, because Sentinel is built into Nomad Enterprise, and not into Terraform, I don't see a good way to make that happen--unless Nomad Enterprise were to add a "would this job pass Sentinel if I submitted it?" endpoint which we could call as part of plan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
nomad_sentinel_policyresource that manages a Sentinel policyfor the Nomad cluster.
Note this PR also runs
govendor add +external, so, uh.... that's whyit's massive.