-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement managing sentinel policies. #27
Conversation
Add a `policy_override` field to `nomad_job` to override any soft-mandatory Sentinel policies that may fail during the job registration. Depends on #27.
Add a nomad_sentinel_policy resource that manages a Sentinel policy for the Nomad cluster.
9f1d4ec
to
e91e31e
Compare
I don't know why half of this is necessary, but govendor says it is. I'll do an audit as a separate PR to fix our vendoring situation, because this is nuts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤣 77k additions, i'll trust you on the vendoring, code looks good to me.
Add a `policy_override` field to `nomad_job` to override any soft-mandatory Sentinel policies that may fail during the job registration. Depends on #27.
Does this feature also include running sentinel policy tests on |
No, this feature is solely for registering the policies within Nomad. Unfortunately, because Sentinel is built into Nomad Enterprise, and not into Terraform, I don't see a good way to make that happen--unless Nomad Enterprise were to add a "would this job pass Sentinel if I submitted it?" endpoint which we could call as part of plan. |
Add a
nomad_sentinel_policy
resource that manages a Sentinel policyfor the Nomad cluster.
Note this PR also runs
govendor add +external
, so, uh.... that's whyit's massive.