Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated to Terraform SDK 0.12 and Nomad API 0.9.1 #61

Merged
merged 3 commits into from
May 9, 2019

Conversation

cgbaker
Copy link
Contributor

@cgbaker cgbaker commented May 8, 2019

added test for nomad 0.9.x spread and affinity support
copied Nomad jobspec parsing into local repo to avoid dep conflict on ugorji/codec, will undo later

@ghost ghost added the size/XXL label May 8, 2019
@cgbaker cgbaker requested review from appilon and paultyng May 8, 2019 18:41
@cgbaker cgbaker marked this pull request as ready for review May 8, 2019 20:14
Chris Baker added 2 commits May 8, 2019 20:27
added test for nomad 0.9.x spread and affinity support
copied Nomad jobspec parsing into local repo to avoid dep conflict on ugorji/codec, will undo later
appilon
appilon previously approved these changes May 9, 2019
Copy link
Contributor

@appilon appilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just noticed the changelog might need updating.

CHANGELOG.md Outdated
* Acceptance tests are gated based on capability (skipped if Nomad endpoint doesn't have certain capability being tested) [GH-53]
* Provider is switched to go modules and the Terraform SDK vendored is bumped to v0.11 [GH-55]
* Acceptance tests are gated based on capability (skipped if Nomad endpoint doesn't have certain capability being tested) ([#53](https://github.com/terraform-providers/terraform-provider-nomad/issues/53))
* Terraform SDK bumped to v0.12-early11 ([#61](https://github.com/terraform-providers/terraform-provider-nomad/issues/61))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update docs to say rc1. Would probably remove line about 0.11 SDK. We have been mentioning that the 0.12 SDK makes the provider compatible with TF 0.12 and TF 0.10/0.11.

@cgbaker cgbaker merged commit 6a374ec into master May 9, 2019
@cgbaker cgbaker deleted the nomad-tf-sdk-updates branch May 9, 2019 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants