update SDK, resolve bugs around deployments and diffs #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
customize diff cannot be run and all computed fields have to be marked as "known at apply" also, fixed deploymentStateRefreshFunc to return the deployment so that deployment info could be set when detach = false. explicitly clearing deployment info when detach = true.
cgbaker
force-pushed
the
b-deployments-and-diffs
branch
from
69ca7c9
to
405c659
Compare
cgbaker
force-pushed
the
b-deployments-and-diffs
branch
from
f522fa0
to
ceec94e
Compare
|
thanks @lgfa29, can you approve the PR? |
lgfa29
approved these changes
May 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated to TF Plugin SDK 1.12.0
resolve #104 : properly set/unset deployment info according to detach
resolve #92 : cannot properly perform customizeDiff when jobspec is not available at diff-time
also removed the vendor/ directory