Fix panic when using invalid JSON jobspec #111
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when the input
jobspec
is in JSON format, but the content doesn't follow the expected Nomad JSON structure, the provider will panic when trying to call the Nomad API.This PR changes the jobpsec parsing logic to gracefully fail when the in this situation.
It also allows for the JSON input to have a root element so that the provider can handle outputs from the Nomad CLI directly: