Support HCL2 on nomad Go package

[thiagonache]

Fix #179

[hashicorp-cla]

All committers have signed the CLA.

[lgfa29]

Thanks so much for the PR @thiagonache!

It's good to see the tests passing now 🙂

Since the HCL2 jobspec parser is still not 100% compatible with the previous one, I think it would be better to have a config flag that could be set to indicate that the HCL2 parser should be used.

Something like this:

resource "nomad_job" "example" {
  jobspec = "..."
  hcl2 = true
}

This config would default to false to maintain backwards compatibility with existing Terraform files.

Let me know of you have any questions.

[thiagonache]

@lgfa29 Please, let me know if that's okay.

[lgfa29]

LGTM 👍

Thank you for the contribution!

[thiagonache]

just curious, what's the release cadence of the provider?

[lgfa29]

just curious, what's the release cadence of the provider?

We don't have any specific cadence, it's usually driven by demand or if there is any critical bug fix.

Are you waiting on this feature? There are a few other PRs that should be merged soon, so we will probably cut a release in the coming days.

[thiagonache]

That’s good enough. I can use my own build for couple days. 🤩

…

On 13 Jan 2021, at 21:15, Luiz Aoqui ***@***.***> wrote:  just curious, what's the release cadence of the provider? We don't have any specific cadence, it's usually driven by demand or if there is any critical bug fix. Are you waiting on this feature? There are a few other PRs that should be merged soon, so we will probably cut a release in the coming days. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[lgfa29]

FYI @thiagonache,

Turns out that loading local files in HCL2 is a bit tricky, so we changed how the hcl2 parameter is specified in #192.

Since your PR has not been released yet, this change won't be listed as a breaking change in our CHANGELOG, but if you are using a custom build you will need to update your Terraform config files.

[thiagonache]

thx for letting me know!!!