Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert Terraform Plugin SDK to v1 #196

Merged
merged 2 commits into from
Jan 20, 2021
Merged

Revert Terraform Plugin SDK to v1 #196

merged 2 commits into from
Jan 20, 2021

Conversation

lgfa29
Copy link
Contributor

@lgfa29 lgfa29 commented Jan 20, 2021

Moving to the Terraform SDK v2 caused Terraform v0.11 to stop working.

Closes #194.

cgbaker
cgbaker approved these changes Jan 20, 2021
View reviewed changes
Copy link
Contributor

@cgbaker cgbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i eyeballed this against #166, looks good
tests are passing and since you manually tested against v0.11.x, this looks good to me!

@lgfa29 lgfa29 merged commit b471847 into master Jan 20, 2021
@lgfa29 lgfa29 deleted the revert-tf-sdk branch January 20, 2021 23:28
@lgfa29
Copy link
Contributor Author

lgfa29 commented Jan 20, 2021

I'm also trying to get the automate test matrix in a good shape so we can run it in a nightly job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgbaker cgbaker cgbaker approved these changes

@jrasell jrasell Awaiting requested review from jrasell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v1.4.12 - Incompatible API version with plugin
2 participants
@lgfa29 @cgbaker