Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new CSI volume capabilities #228

Merged
merged 2 commits into from
May 18, 2021
Merged

Add new CSI volume capabilities #228

merged 2 commits into from
May 18, 2021

Conversation

lgfa29
Copy link
Contributor

@lgfa29 lgfa29 commented May 13, 2021

Add a new resource, nomad_external_volume to use the new CSI capability in Nomad 1.1.0 to create and register external volumes through Nomad.

Also update the existing nomad_volume resource to deprecate fields, following the official guidelines.

Closes #208

@lgfa29 lgfa29 requested review from jrasell and jazzyfresh May 13, 2021 23:44
@lgfa29 lgfa29 linked an issue May 13, 2021 that may be closed by this pull request
Base automatically changed from update-nomad-1.1.0-beta1 to main May 14, 2021 14:11
Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work!

@lgfa29 lgfa29 merged commit 2c91c2e into main May 18, 2021
@lgfa29 lgfa29 deleted the nomad-external-volume branch May 18, 2021 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support new CSI dynamic volumes
2 participants