Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acl: add ACL Role resource and data sources #284

Merged
merged 5 commits into from
Oct 20, 2022
Merged

Conversation

jrasell
Copy link
Member

@jrasell jrasell commented Sep 5, 2022

This change adds a new nomad_acl_role resource along with nomad_acl_role and nomad_acl_roles datasources.

In order to raise the change, the Nomad dependency has been updated to latest. This should be fixed to a release tag once 1.4.0 is released.

The tests do not currently run because the CI process requires a released version of Nomad :D. We can either merge this as is, or hold off until 1.4.0; but raising the PR now for early review.

@jrasell jrasell requested a review from lgfa29 September 5, 2022 15:33
@jrasell jrasell self-assigned this Sep 5, 2022
@jrasell jrasell marked this pull request as draft September 12, 2022 10:37
@lgfa29 lgfa29 mentioned this pull request Sep 22, 2022
@lgfa29 lgfa29 force-pushed the jrasell/f-acl-role-resource branch from 1b028f2 to 32347f8 Compare October 20, 2022 14:37
@lgfa29 lgfa29 force-pushed the jrasell/f-acl-role-resource branch from 5040be6 to 62f73ab Compare October 20, 2022 15:04
@lgfa29 lgfa29 marked this pull request as ready for review October 20, 2022 15:06
Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@lgfa29 lgfa29 merged commit 315782b into main Oct 20, 2022
@lgfa29 lgfa29 deleted the jrasell/f-acl-role-resource branch October 20, 2022 15:14
elprans pushed a commit to edgedb/terraform-provider-nomad that referenced this pull request Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants