Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add option to skip tls verfication #319

Merged
merged 3 commits into from
Jun 1, 2023
Merged

feat: add option to skip tls verfication #319

merged 3 commits into from
Jun 1, 2023

Conversation

janory
Copy link
Contributor

@janory janory commented Apr 25, 2023

Add skip_verify as an optional parameter to the schema to be able to skip TLS verification.

@hashicorp-cla
Copy link

hashicorp-cla commented Apr 25, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

lgfa29
lgfa29 approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @janory 👋

Apologies for the delay in getting this reviewed, but it looks great! I just pushed a commit to add a CHANGELOG entry.

Thank you very much for the contribution 😄

@lgfa29 lgfa29 merged commit f30b1f6 into hashicorp:main Jun 1, 2023
1 check passed
@janory
Copy link
Contributor Author

janory commented Jun 1, 2023

Hi @lgfa29! 👋

Thanks for checking & merging the PR. 👍

@lgfa29 lgfa29 added this to the 2.0.0 milestone Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgfa29 lgfa29 lgfa29 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@janory @hashicorp-cla @lgfa29