making bind_name optional when bind_type is management #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkazmierczak
approved these changes
Jun 5, 2023
lgfa29
approved these changes
Jun 5, 2023
|
Adjusted the validateNomadACLBindingRule formatting based on @lgfa29 feedback. I am definitely not used to reaching for switch statements so they don't come to my mind first, and I personally find it a bit harder to read, but I think that's just because I so rarely use them. Thank you for the suggestion. I can definitely see how it would be easier to read once I train my brain a bit more. |
When creating a ACL binding rule, the bind name must not be defined but only when the bind_type is set to management. https://developer.hashicorp.com/nomad/docs/commands/acl/binding-rule/create Fixes hashicorp#324
regner
force-pushed
the
fix-acl-binding-rule
branch
from
b94b74e
to
e4d1830
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a ACL binding rule, the bind name must not be defined but only when the bind_type is set to management.
https://developer.hashicorp.com/nomad/docs/commands/acl/binding-rule/create
Fixes #324