Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource and data sources for node pools #340

Merged
merged 4 commits into from
Jul 13, 2023
Merged

Add resource and data sources for node pools #340

merged 4 commits into from
Jul 13, 2023

Conversation

lgfa29
Copy link
Contributor

@lgfa29 lgfa29 commented Jul 7, 2023

Nomad dependency will need to be updated after GA, but implementation is ready for review.

Targets upgrade-sdkv2 branch to solve a bug I hit in tests using SDK v1.

@lgfa29 lgfa29 requested review from tgross and jrasell July 7, 2023 22:32
lgfa29 added a commit that referenced this pull request Jul 7, 2023
Base automatically changed from upgrade-sdkv2 to main July 11, 2023 15:05
lgfa29 added a commit that referenced this pull request Jul 11, 2023
Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a couple of minor comments.

nomad/resource_node_pool.go Outdated Show resolved Hide resolved
nomad/resource_node_pool.go Show resolved Hide resolved
@lgfa29 lgfa29 merged commit a4ca832 into main Jul 13, 2023
1 of 2 checks passed
@lgfa29 lgfa29 deleted the f-node-pools branch July 13, 2023 20:42
@lgfa29 lgfa29 added this to the 2.0.0 milestone Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants