Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

volumes: add timeout and retry on create and delete #346

Merged
merged 3 commits into from
Jul 13, 2023
Merged

volumes: add timeout and retry on create and delete #346

merged 3 commits into from
Jul 13, 2023

Conversation

lgfa29
Copy link
Contributor

@lgfa29 lgfa29 commented Jul 12, 2023

Add retry logic during volume create, register, deregister and delete.

Update deprecated resources since the deprecation has not happen yet, so keep them updated until v2.0.0 is out.

Closes #335

@lgfa29 lgfa29 mentioned this pull request Jul 12, 2023
Closed
Base automatically changed from update-tf-sdk-and-nomad to main July 12, 2023 21:31
jrasell
jrasell approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor docs suggestions, but LGTM otherwise.

website/docs/r/volume.html.markdown Outdated Show resolved Hide resolved
website/docs/r/volume.html.markdown Outdated Show resolved Hide resolved
website/docs/r/csi_volume_registration.html.markdown Outdated Show resolved Hide resolved
website/docs/r/csi_volume_registration.html.markdown Outdated Show resolved Hide resolved
website/docs/r/external_volume.html.markdown Outdated Show resolved Hide resolved
website/docs/r/external_volume.html.markdown Outdated Show resolved Hide resolved
website/docs/r/csi_volume.html.markdown Outdated Show resolved Hide resolved
website/docs/r/csi_volume.html.markdown Outdated Show resolved Hide resolved
@lgfa29 @jrasell
Apply suggestions from code review
d60ccd4 
Co-authored-by: James Rasell <jrasell@users.noreply.github.com>
@lgfa29
Copy link
Contributor Author

lgfa29 commented Jul 13, 2023

Copy and paste gone wild 😅

Thanks for the fixes!

@lgfa29 lgfa29 merged commit 2feb0cd into main Jul 13, 2023
1 of 2 checks passed
@lgfa29 lgfa29 deleted the csi-timeout-retry branch July 13, 2023 20:16
@lgfa29 lgfa29 mentioned this pull request Aug 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrasell jrasell jrasell approved these changes

@pkazmierczak pkazmierczak Awaiting requested review from pkazmierczak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resource "nomad_external_volume" destruction fails because volume is still not detached
2 participants
@lgfa29 @jrasell