Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

namespace: add node pool configuration #355

Merged
merged 5 commits into from
Jul 28, 2023
Merged

namespace: add node pool configuration #355

merged 5 commits into from
Jul 28, 2023

Conversation

lgfa29
Copy link
Contributor

@lgfa29 lgfa29 commented Jul 25, 2023 •
edited

Add node_pool_config to namespace resource and data source.

Broken tests fixed in #354

Closes #352

lgfa29 added a commit that referenced this pull request Jul 25, 2023
@lgfa29
changelog: add entry for #355
a7c71b4
jrasell
jrasell approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

CHANGELOG.md Outdated Show resolved Hide resolved
@lgfa29 lgfa29 merged commit 63e446b into main Jul 28, 2023
3 checks passed
@lgfa29 lgfa29 deleted the f-namespace-np-config branch July 28, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrasell jrasell jrasell approved these changes

@pkazmierczak pkazmierczak Awaiting requested review from pkazmierczak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing namespace node pool configuration
2 participants
@lgfa29 @jrasell