resource/job: remove attribute allocation_ids #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Storing the list of allocation IDs in a `nomad_job` resource can lead to ever-changing plans since the list can change outsite of Terraform. Retrieving this type of information is better suited for a data source. The Terraform provider deprecation guide recommends attributes to be first marked as deprecated before full removal in the next major release. Given that the next release will be a major release, this commit introduces a breaking change in behaviour (allocation IDs are not fetched by default anymore) but provides a fallback with the `read_allocation_ids` attribute. Both attributes are marked as deprecated and will be removed in the next major release.
gulducat
approved these changes
Jul 26, 2023
|
Yup. This option causes several tests to be flaky and, since it will be removed in the future, I didn't think it was worth to keep a flaky test around. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storing the list of allocation IDs in a
nomad_jobresource can lead to ever-changing plans since the list can change outsite of Terraform.Retrieving this type of information is better suited for a data source.
The Terraform provider deprecation guide recommends attributes to be first marked as deprecated before full removal in the next major release.
Given that the next release will be a major release, this commit introduces a breaking change in behaviour (allocation IDs are not fetched by default anymore) but provides a fallback with the
read_allocation_idsattribute.Both attributes are marked as deprecated and will be removed in the next major release.
nomad_allocationsdata source added in #358