Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set rand seed when initializing provider #160

Merged
merged 5 commits into from
Nov 17, 2022
Merged

Set rand seed when initializing provider #160

merged 5 commits into from
Nov 17, 2022

Conversation

SBGoods
Copy link
Contributor

@SBGoods SBGoods commented Nov 15, 2022

Closes #159

@SBGoods SBGoods requested a review from a team as a code owner November 15, 2022 20:56
@SBGoods SBGoods mentioned this pull request Nov 15, 2022
Closed
1 task
@bflad bflad added the bug label Nov 16, 2022
@bflad bflad added this to the v3.2.1 milestone Nov 16, 2022
bflad
bflad approved these changes Nov 16, 2022
View reviewed changes
Copy link
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀 (For context, this logic was present before #150.)

bflad
bflad reviewed Nov 16, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@SBGoods SBGoods merged commit 056cf6f into main Nov 17, 2022
@SBGoods SBGoods deleted the setRandIntSeed branch November 17, 2022 15:10
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
bug size/XS
Projects
None yet
Milestone
v3.2.1
Development

Successfully merging this pull request may close these issues.

[3.2.0] null_resource id becomes constant, semi-random and unaffected by changing of triggers values
2 participants
@SBGoods @bflad