Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tfversion variables instead of go-version directly for function testing #221

Merged
merged 1 commit into from
May 24, 2024

Conversation

bflad
Copy link
Contributor

@bflad bflad commented May 24, 2024

Reference: #220

Consuming developers should not directly need to worry about github.com/hashicorp/go-version unless they want to use that Go module. Provider-defined functions testing was releasing in this template repository before the Terraform 1.8.0 version variable in the terraform-plugin-testing tfversion package was available. Now that the variable is present, we can remove go-version as a direct dependency, simplifying both the code and dependency management slightly.

…esting

Reference: #220

Consuming developers should not directly need to worry about `github.com/hashicorp/go-version` unless they want to use that Go module. Provider-defined functions testing was releasing in this template repository before the Terraform 1.8.0 version variable in the terraform-plugin-testing `tfversion` package was available. Now that the variable is present, we can remove go-version as a direct dependency, simplifying both the code and dependency management slightly.
@bflad bflad added the dependencies Pull requests that update a dependency file label May 24, 2024
@bflad bflad requested a review from a team as a code owner May 24, 2024 16:09
Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@bflad bflad merged commit 37b9fa0 into main May 24, 2024
15 checks passed
@bflad bflad deleted the bflad/use-testing-variable branch May 24, 2024 16:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants