Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/tfe_workspace: support assigning an SSH key #38

Merged
merged 1 commit into from
Nov 26, 2018

Conversation

svanharmelen
Copy link
Contributor

No description provided.

@ghost ghost added the size/L label Nov 24, 2018
@robinbowes
Copy link

I just tested this:

Terraform will perform the following actions:

  ~ module.rb-test-ssh-id.tfe_workspace.this
      ssh_key_id: "" => "sshkey-XXXXXXXXXXXXX"


Plan: 0 to add, 1 to change, 0 to destroy.

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

module.rb-test-ssh-id.tfe_workspace.this: Modifying... (ID: MyOrgName/rb-test-ssh-id)
  ssh_key_id: "" => "sshkey-XXXXXXXXXXXXX"
module.rb-test-ssh-id.tfe_workspace.this: Modifications complete after 1s (ID: MyOrgName/rb-test-ssh-id)

Apply complete! Resources: 0 added, 1 changed, 0 destroyed.

Looking good. Get it merged and released! :)

Copy link

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@svanharmelen,

LGTM aside from one very minor (non blocking) comment 👍

tfe/resource_tfe_workspace_test.go Show resolved Hide resolved
@svanharmelen svanharmelen merged commit bf3f959 into master Nov 26, 2018
@svanharmelen svanharmelen deleted the f-workspace-ssh branch November 26, 2018 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants