-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TFE Backwards Compatibility contrib documentation #1011
Conversation
d8a1153
to
66695e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation was clear and helpful!!
ca5c23d
to
281a6f1
Compare
This PR closes #996 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hate to continue to push back on this but I still think we could get away indefinitely with not adding this type of condition to this repo. Why not just if tmAccess.ProjectAccess != nil { ... if tmAccess.WorkspaceAccess != nil {
? Not only does it look better, but it doesn't create any protocol dependency. 🤷
281a6f1
to
ebcc272
Compare
Yeah implicit checks are probably the simplest option here (and maybe I should call it out as the recommended approach). I like this kind of check for instances where |
209753a
to
f4ce7c6
Compare
This document outlines how to handle unsupported TFE versions, TFE only behavior, and updating the documentation to reflect supported TFE versions.
f4ce7c6
to
20c9986
Compare
"settings": tmAccess.ProjectAccess.ProjectSettingsPermission, | ||
"teams": tmAccess.ProjectAccess.ProjectTeamsPermission, | ||
}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"settings": tmAccess.ProjectAccess.ProjectSettingsPermission, | |
"teams": tmAccess.ProjectAccess.ProjectTeamsPermission, | |
}} | |
"settings": tmAccess.ProjectAccess.ProjectSettingsPermission, | |
"teams": tmAccess.ProjectAccess.ProjectTeamsPermission, | |
}} |
Description
Add docs related to TFE backwards compatibility.
Fixes #996
Remember to:
Testing plan
External links
Include any links here that might be helpful for people reviewing your PR. If there are none, feel free to delete this section.
Output from acceptance tests
Please run applicable acceptance tests locally and include the output here. See testing.md to learn how to run acceptance tests.
If you are an external contributor, your contribution(s) will first be reviewed before running them against the project's CI pipeline.