Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TF-9704 Added organization_scoped resource to oauth client #1142

Merged

Conversation

Netra2104
Copy link
Contributor

@Netra2104 Netra2104 commented Nov 16, 2023

Description

OrganizationScoped was added to the oauth client so that the user can scope it to an organization optionally.
By default the value of organization scoped is true when it is first created.

Remember to:

Testing plan

Run the tests locally

External links

Include any links here that might be helpful for people reviewing your PR. If there are none, feel free to delete this section.

Output from acceptance tests

Please run applicable acceptance tests locally and include the output here. See testing.md to learn how to run acceptance tests.

If you are an external contributor, your contribution(s) will first be reviewed before running them against the project's CI pipeline.

=== RUN   TestAccTFEOAuthClient_basic
--- PASS: TestAccTFEOAuthClient_basic (9.48s)
PASS

Documentation

Screenshot 2023-11-17 at 11 15 12 AM

Screenshot 2023-11-17 at 11 15 21 AM

@Netra2104 Netra2104 added the wip label Nov 16, 2023
@Netra2104 Netra2104 requested a review from a team as a code owner November 16, 2023 18:07
@Netra2104 Netra2104 force-pushed the Netra2104/TF-9704-add-organization-scoped-resource-oauth-client branch from e470e94 to a2893cc Compare November 17, 2023 16:14
@Netra2104 Netra2104 removed the wip label Nov 22, 2023
@Netra2104 Netra2104 requested a review from a team November 22, 2023 19:38
Copy link
Contributor

@hs26gill hs26gill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the lint issue else LGTM!

@Netra2104 Netra2104 force-pushed the Netra2104/TF-9704-add-organization-scoped-resource-oauth-client branch 2 times, most recently from e83f419 to 17dc929 Compare November 27, 2023 20:27
netramali and others added 3 commits November 29, 2023 11:09
Co-authored-by: UKEME BASSEY <ukeme.bassey@hashicorp.com>
Co-authored-by: UKEME BASSEY <ukeme.bassey@hashicorp.com>
@Netra2104 Netra2104 force-pushed the Netra2104/TF-9704-add-organization-scoped-resource-oauth-client branch from 502751c to 1972dc8 Compare November 29, 2023 16:10
@netramali netramali merged commit 38f260d into main Apr 9, 2024
9 checks passed
@netramali netramali deleted the Netra2104/TF-9704-add-organization-scoped-resource-oauth-client branch April 9, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants